Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link indicator on 'Shared via link'-page #7355

Merged
merged 5 commits into from
Jul 27, 2022
Merged

Fix link indicator on 'Shared via link'-page #7355

merged 5 commits into from
Jul 27, 2022

Conversation

JammingBen
Copy link
Contributor

Description

We've fixed the icon and the sidebar for the link indicator on the "Shared via link"-page.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jul 27, 2022
@JammingBen JammingBen marked this pull request as ready for review July 27, 2022 10:07
@ownclouders
Copy link
Contributor

ownclouders commented Jul 27, 2022 •
edited
Loading

Results for oCISSharingInternal1 https://drone.owncloud.com/owncloud/web/27068/60/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalGroups-shareWithGroups_feature-L246.png

webUISharingInternalGroups-shareWithGroups_feature-L246.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@JammingBen JammingBen force-pushed the fix-link-indicator-shared-via-link-page branch from a248ba8 to 741e02b Compare July 27, 2022 13:15
@JammingBen JammingBen requested a review from kulmann July 27, 2022 13:22
kulmann
kulmann approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 01b024a into master Jul 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-link-indicator-shared-via-link-page branch July 27, 2022 14:13
@micbar micbar mentioned this pull request Aug 11, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

@lookacat lookacat Awaiting requested review from lookacat

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shared-via-Link: wrong link-target & icon
3 participants
@JammingBen @ownclouders @kulmann